State management: Base viewModel #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrodrick
reviewed
Aug 15, 2023
example/app/src/main/java/com/rootstrap/androidcomposebase/ui/base/BaseViewModel.kt
Outdated
Show resolved
Hide resolved
hrodrick
reviewed
Aug 15, 2023
Contributor
hrodrick
left a comment
hrodrick
left a comment
There was a problem hiding this comment.
Nice work! Just left a comment
| .matches() || password.isEmpty() | ||
| updateUiState { it.copy(password = password, showPasswordError = !isPasswordValid) } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
probably you can add a function here:
private fun validateInput(input: String, regex: Regex): Boolean {
return regex.matches(input) || input.isEmpty()
}
to avoid duplicating the validation checks, wdyt?
Collaborator
There was a problem hiding this comment.
The validation logic runs every time the user types, this could be inefficient if validating too frequently
You could debounce the validation to only run after the user stops typing or only validate when the onLogingButtonClicked is called.
wdyt?
Contributor
Author
There was a problem hiding this comment.
I'll leave a todo
| import kotlinx.coroutines.flow.update | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| open class BaseViewModel<UiStateType : UiState, NavigationEventT : Any>( |
Collaborator
There was a problem hiding this comment.
I think this class could be abstract
ximenaperez
approved these changes
Aug 17, 2023
hrodrick
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#19
closes #19
Description
Added base view model in the app and in the example app modules.
Added interface for uiState