Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #247 - explicitly declare position_proportional_gain parameter #248

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Fix #247 - explicitly declare position_proportional_gain parameter #248

merged 1 commit into from
Mar 15, 2024

Conversation

Fixit-Davide
Copy link
Contributor

With this patch, you can change position gain with this config file lines:

gz_ros_control:
  ros__parameters:
    position_proportional_gain: 0.5

@Fixit-Davide Fixit-Davide requested a review from ahcorde as a code owner March 14, 2024 12:59
@roncapat roncapat mentioned this pull request Mar 14, 2024
Closed
@ahcorde ahcorde merged commit 94745e6 into ros-controls:master Mar 15, 2024
4 of 8 checks passed
@ahcorde
Copy link
Collaborator

ahcorde commented Mar 15, 2024

https://github.com/Mergifyio backport humble iron

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 15, 2024 •
edited
Loading

backport humble iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@Fixit-Davide @mergify
Fix #247 (#248)
5814b14 
(cherry picked from commit 94745e6)
mergify bot pushed a commit that referenced this pull request Mar 15, 2024
@Fixit-Davide @mergify
Fix #247 (#248)
db449db 
(cherry picked from commit 94745e6)
ahcorde pushed a commit that referenced this pull request Mar 15, 2024
@mergify @Fixit-Davide
Fix #247 (#248) (#250)
501be7f 
(cherry picked from commit 94745e6)

Co-authored-by: Graziato Davide <85335579+Fixit-Davide@users.noreply.github.com>
ahcorde pushed a commit that referenced this pull request Mar 15, 2024
@mergify @Fixit-Davide
Fix #247 (#248) (#251)
32e5a87 
(cherry picked from commit 94745e6)

Co-authored-by: Graziato Davide <85335579+Fixit-Davide@users.noreply.github.com>
@TipluJacob TipluJacob mentioned this pull request Mar 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fixit-Davide @ahcorde