-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/rt pub define #211
Open
firesurfer
wants to merge
10
commits into
ros-controls:master
Choose a base branch
from
firesurfer:refactor/rt_pub_define
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor/rt pub define #211
firesurfer
wants to merge
10
commits into
ros-controls:master
from
firesurfer:refactor/rt_pub_define
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ARK3r,
bmagyar,
harderthan,
livanov93,
LukasMacha97,
saikishor and
VX792
November 28, 2024 13:00
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 72.72% 75.00% +2.27%
==========================================
Files 7 7
Lines 429 468 +39
Branches 71 78 +7
==========================================
+ Hits 312 351 +39
Misses 73 73
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup PR for #210
The approach in general probably needs some discussion. But I think it is a first step into removing conditional compilation based on a define set in a different file.
This implementation keeps the ability to select the polling mode via the define but prints a deprecation message.