First step towards modernizing the rt publisher #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
christophfroehlich,
erickisos,
LukasMacha97,
progtologist and
VX792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 72.72% 73.16% +0.43%
==========================================
Files 7 7
Lines 429 436 +7
Branches 71 72 +1
==========================================
+ Hits 312 319 +7
Misses 73 73
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
approved these changes
Nov 29, 2024
aprotyas
reviewed
Nov 29, 2024
aprotyas
reviewed
Nov 29, 2024
|
@christophfroehlich anything missing in order to get this merged? |
|
another review ;) |
|
And I just added a test for the tryPublish method :) @saikishor would you mind reviewing this PR ? |
I'll check it during the day. I have some pending review already |
saikishor
approved these changes
Dec 2, 2024
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
saikishor
approved these changes
Dec 13, 2024
christophfroehlich
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
(cherry picked from commit e58c7ad)
christophfroehlich
pushed a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the rt publisher is one of the most commonly used tools in this package.
When ever I was using it I stumbled upon its "weird" API.
This PR is a first step towards modernizing the RealtimePublisher class, providing a tiny bit of comfort by adding a
tryPublishmethod and providing some typedefs similar to the rclcpp::Publisher.I plan to add a follow up PR where I refactor the NON_POLLING define into a template parameter.