-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for params_file
parameter in spawner/unspawner tests (backport #1754)
#1839
Conversation
Cherry-pick of 84e85f9 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor? |
43088b7
to
6386703
Compare
5107135
to
a87e11c
Compare
a87e11c
to
e9d2e82
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## iron #1839 +/- ##
==========================================
- Coverage 62.41% 62.40% -0.02%
==========================================
Files 112 112
Lines 12984 13039 +55
Branches 8782 8831 +49
==========================================
+ Hits 8104 8137 +33
+ Misses 952 943 -9
- Partials 3928 3959 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Overview
params_file
parameter in test_spawner_unspawner.cpp #1702params_file
parameter in the test_spawner_unspawner.cpp.This is an automatic backport of pull request #1754 done by [Mergify](https://mergify.com).