Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for params_file parameter in spawner/unspawner tests (backport #1754) #1839

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 3, 2024

Overview


This is an automatic backport of pull request #1754 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Nov 3, 2024
Copy link
Contributor Author

mergify bot commented Nov 3, 2024

Cherry-pick of 84e85f9 has failed:

On branch mergify/bp/iron/pr-1754
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 84e85f9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   controller_manager/test/test_spawner_unspawner.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Nov 3, 2024

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor?

@saikishor saikishor force-pushed the mergify/bp/iron/pr-1754 branch from 43088b7 to 6386703 Compare November 3, 2024 17:48
@saikishor saikishor force-pushed the mergify/bp/iron/pr-1754 branch 2 times, most recently from 5107135 to a87e11c Compare November 3, 2024 18:26
@saikishor saikishor force-pushed the mergify/bp/iron/pr-1754 branch from a87e11c to e9d2e82 Compare November 3, 2024 18:48
@saikishor saikishor enabled auto-merge (squash) November 3, 2024 19:00
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 47.27273% with 29 lines in your changes missing coverage. Please review.

Project coverage is 62.40%. Comparing base (15c9a14) to head (e9d2e82).
Report is 1 commits behind head on iron.

Files with missing lines Patch % Lines
controller_manager/test/test_spawner_unspawner.cpp 47.27% 0 Missing and 29 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1839      +/-   ##
==========================================
- Coverage   62.41%   62.40%   -0.02%     
==========================================
  Files         112      112              
  Lines       12984    13039      +55     
  Branches     8782     8831      +49     
==========================================
+ Hits         8104     8137      +33     
+ Misses        952      943       -9     
- Partials     3928     3959      +31     
Flag Coverage Δ
unittests 62.40% <47.27%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../controller_manager/controller_manager_services.py 70.68% <ø> (ø)
controller_manager/test/test_spawner_unspawner.cpp 56.22% <47.27%> (-1.36%) ⬇️

... and 2 files with indirect coverage changes

@saikishor saikishor merged commit 3a48508 into iron Nov 3, 2024
10 of 11 checks passed
@saikishor saikishor deleted the mergify/bp/iron/pr-1754 branch November 3, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants