Skip to content

Conversation

@jordan-palacios
Copy link
Member

Current version fails in our setup where some actuator interfaces are exposed with no corresponding joint interface (intended).

This PR rewrites some of the configure check to allow this situation. Also, we add another check to make sure there is at least one valid joint-actuator handle pair.

Let incomplete pair-wise handles through, but make sure at least one
valid one pair is present
@jordan-palacios jordan-palacios force-pushed the fix/diff_transmission_checks branch from ad13b8c to 3473218 Compare November 14, 2025 12:33
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.62%. Comparing base (fc77935) to head (3473218).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ansmission_interface/differential_transmission.hpp 78.78% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2812   +/-   ##
=======================================
  Coverage   89.61%   89.62%           
=======================================
  Files         152      152           
  Lines       17774    17816   +42     
  Branches     1460     1455    -5     
=======================================
+ Hits        15929    15967   +38     
- Misses       1253     1263   +10     
+ Partials      592      586    -6     
Flag Coverage Δ
unittests 89.62% <85.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
..._interface/test/differential_transmission_test.cpp 99.60% <100.00%> (+0.02%) ⬆️
...ansmission_interface/differential_transmission.hpp 75.94% <78.78%> (+2.61%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@saikishor saikishor added backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted. labels Nov 14, 2025
Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@christophfroehlich christophfroehlich merged commit 23337e5 into ros-controls:master Nov 14, 2025
19 checks passed
mergify bot pushed a commit that referenced this pull request Nov 14, 2025
mergify bot pushed a commit that referenced this pull request Nov 14, 2025
robkwan pushed a commit to robkwan/ros2_control that referenced this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants