-
Notifications
You must be signed in to change notification settings - Fork 386
Improving differential_transmission configure checks #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving differential_transmission configure checks #2812
Conversation
Let incomplete pair-wise handles through, but make sure at least one valid one pair is present
ad13b8c to
3473218
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2812 +/- ##
=======================================
Coverage 89.61% 89.62%
=======================================
Files 152 152
Lines 17774 17816 +42
Branches 1460 1455 -5
=======================================
+ Hits 15929 15967 +38
- Misses 1253 1263 +10
+ Partials 592 586 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
(cherry picked from commit 23337e5)
(cherry picked from commit 23337e5)
Current version fails in our setup where some actuator interfaces are exposed with no corresponding joint interface (intended).
This PR rewrites some of the configure check to allow this situation. Also, we add another check to make sure there is at least one valid joint-actuator handle pair.