Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Dec 3, 2025

Description

This PR updates a RCLCPP_WARN_EXPRESSION call in controller_interface_base.cpp to use fmt::format instead of printf-style formatting.

Changes

  • Replaced %ld/%d format specifiers with fmt::format for platform-independent logging.
  • Preserved the original logic: ctrl_itf_params_.update_rate is updated to achievable_hz only if the requested update rate is not achievable.
  • Ensures consistent behavior across different platforms and avoids compilation warnings on macOS and other systems.

Motivation

Printf-style format specifiers can cause warnings or undefined behavior depending on the platform (e.g., long vs int64_t). Using fmt::format ensures type safety and platform independence while keeping the original functionality.


This is an automatic backport of pull request #2880 done by [Mergify](https://mergify.com).

@christophfroehlich christophfroehlich merged commit cbb9b32 into mergify/bp/jazzy/pr-2828 Dec 3, 2025
2 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/mergify/bp/jazzy/pr-2828/pr-2880 branch December 3, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants