Install spawner/unspawner using console_script entrypoint

[wmmc88]

fixes #605

[wmmc88]

builds failing because the backported feature hasn't been released yet.

Feature: May 10 2021
Galactic Backport: Dec 7 2021
Latest Ament_cmake release: Oct 29 2021

[bmagyar]

ament/ament_cmake#373

[destogl]

@wmmc88 it seems you missed some argument:

  CMake Error at /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:39 (message):
    ament_python_install_package() called with unused arguments:
    SCRIPTS_DESTINATION;lib/controller_manager
  Call Stack (most recent call first):
    /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:33 (_ament_cmake_python_install_package)
    CMakeLists.txt:156 (ament_python_install_package)

[wmmc88]

@wmmc88 it seems you missed some argument:

  CMake Error at /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:39 (message):
    ament_python_install_package() called with unused arguments:
    SCRIPTS_DESTINATION;lib/controller_manager
  Call Stack (most recent call first):
    /opt/ros/galactic/share/ament_cmake_python/cmake/ament_python_install_package.cmake:33 (_ament_cmake_python_install_package)
    CMakeLists.txt:156 (ament_python_install_package)

That doesn't fail once ament_cmake releases to galactic. It's a new arg that was added a while ago

[destogl]

That doesn't fail once ament_cmake releases to galactic. It's a new arg that was added a while ago

OK, then we just have to wait.

[bmagyar]

The release was made, we only need to wait for the next sync with this

[destogl]

@bmagyar I am approving this so we can simply retrigger CI and merge this (tomorrow).

[wmmc88]

@bmagyar I am approving this so we can simply retrigger CI and merge this (tomorrow).

I think last Friday was only a rolling sync. Idk when the next galactic sync is but there hasn't been one since 12-27-21. Next foxy sync is 2-8-22 (https://discourse.ros.org/t/preparing-for-foxy-sync-and-patch-release-2022-02-08/24050) so maybe soon?

[wmmc88]

Looks like galactic was just synced:
https://discourse.ros.org/t/preparing-for-galactic-sync-2022-02-09/24176/4?u=wmmc88

[wmmc88]

All ci passes after sync!