Restructuring for example_1 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bmagyar,
DasRoteSkelett,
destogl,
malapatiravi,
peterdavidfagan and
progtologist
destogl
reviewed
Feb 7, 2023
example_1/hardware/include/ros2_control_demo_example_1/visibility_control.h
Outdated
Show resolved
Hide resolved
example_1/bringup/launch/test_forward_position_controller.launch.py
Outdated
Show resolved
Hide resolved
destogl
approved these changes
Feb 7, 2023
Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
destogl
reviewed
Feb 9, 2023
25 tasks
bmagyar
reviewed
Feb 10, 2023
bmagyar
approved these changes
Feb 10, 2023
|
Do we need the camera link, hokuyo mesh etc in these example repositories? I added the missing mesh to example_1, should I do that for all the others rrbot-examples too? |
|
@christophfroehlich updated the base branch, now we have a conflict! :D |
christophfroehlich
force-pushed
the
example_1
branch
from
757e7b6
to
9b12209
Compare
fixed that. |
destogl
added a commit
that referenced
this pull request
Mar 8, 2023
* First compilable version * Fix wrong paths * Fix rst * Update copyright Co-authored-by: Dr. Denis <denis@stoglrobotics.de> * Restructure cmakelists * Add maintainer * Cleanup old paths * Update Dr. Denis' Email and add him as author. * Update maintainer * Use test_nodes from ros2_controllers * Fix trailing whitespaces * Fix rviz display * Add image to readme --------- Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #231