Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JTC actionserver callbacks #336

Closed
bmagyar opened this issue Apr 20, 2022 · 2 comments
Closed

Rename JTC actionserver callbacks #336

bmagyar opened this issue Apr 20, 2022 · 2 comments
Labels
good second issue

Comments

@bmagyar
Copy link
Member

bmagyar commented Apr 20, 2022

these callback aren't named properly anymore. the follow-up of accepting the goal is meant to happen in the 3rd bound function which is confusingly named feedback_setup_callback. we should rename them

https://docs.ros2.org/galactic/api/rclcpp_action/create__server_8hpp.html

Originally posted by @bmagyar in #190 (comment)
@christophfroehlich
Copy link
Contributor

@bmagyar haven't you fixed that already with #397?

@bmagyar
Copy link
Member Author

bmagyar commented Sep 11, 2023

Yup, thank you!

Fixed by #397

@bmagyar bmagyar closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good second issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophfroehlich @bmagyar