JTC touchups #abi-breaking #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bmagyar
commented
Jul 29, 2022
•
bmagyar
commented
- Renamed the actionserver callbacks to better describe the reason
- Moved the topic callback to a member function for testability and ease of finding it
- Comments cleanup
github-actions
bot
requested review from
destogl,
jaron-l,
kasiceo,
peterdavidfagan,
UsamaHamayun1 and
VX792
destogl
approved these changes
Jul 29, 2022
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
destogl
reviewed
Jul 30, 2022
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
bmagyar
commented
Jul 30, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
bmagyar
commented
Jul 30, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
bmagyar
commented
Jul 30, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
bmagyar
commented
Jul 30, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
bmagyar
commented
Jul 30, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Denis Štogl <denis@stogl.de>
mamueluth
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Aug 26, 2022
…reaking Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.