Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admittance_controller load test #583

Open
bmagyar opened this issue Apr 26, 2023 · 0 comments
Open

Fix admittance_controller load test #583

bmagyar opened this issue Apr 26, 2023 · 0 comments
Labels
good second issue

Comments

@bmagyar
Copy link
Member

bmagyar commented Apr 26, 2023 •
edited
Loading

After fixing all controller loading tests, I discovered that this one is actually fairly broken.
#569

The steps to fix this is fairly straightforward.
Apply a similar fix from #569 to the admittance controller load test, re-run the tests and start fixing issues one by one. The first one will be related to missing required parameters, you can quick fix that by using the other params setup from the tests.
@bmagyar bmagyar mentioned this issue Apr 27, 2023
Merged
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this issue Jun 7, 2023
@sp-sophia-labs @jaron-l
@mergify @bmagyar @hoang-david-ha
Namespace Loaded Controllers (ros-controls#852)
30131b4 
* ci: 👷 Add ABI check to ros_indiustrial ci (ros-controls#597)

* ci: 👷 Add ABI check to ros_indiustrial ci

refs: ros-controls#583

* ci: 👷 change notation of ci

* ci: 👷 change branch reference

* ci: 👷 address PR comments

* move abi check to spearate workflow
* check abi against base ref
* PR against galactic branch

* No need to get angles from source anymore, causes issues now (backport ros-controls#616) (ros-controls#617)

* No need to get angles from source anymore, causes issues now (ros-controls#616)

(cherry picked from commit 2275f06)

* fix spelling

* Apply suggestions from code review

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>

* first commit

* namespace support for load_controller in controller_manager

* cleaning up, renaming variables and other small fixes

* renaming namespace to manager_namespace to avoid errors

* removing namespaced param

* add gitignore for __pycache__ folders

* remove pycache ignore

* run 'pre-commit run --all' and fix flake8 errors

* switch init declaration (revert)

* remove the need to modify hardware interface

* remove useless function arguments

* removing namespace argument from manager services

* remove namespace from service messages

* namespaced->prefixed + minor changes for readability

* fix forgotten rebase conflicts

* remove galactic related files

* revert controller_manager constructor changes

Co-authored-by: Jaron <13423952+jaron-l@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: badr.moutalib <badr.moutalib@accenture.com>
Co-authored-by: Hoang David HA <hoang.david.ha@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good second issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmagyar