Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Cleanup API #1128

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[JTC] Cleanup API #1128

wants to merge 9 commits into from

Conversation

christophfroehlich
Copy link
Contributor

The last bullet point and closes #944.

The methods

fill_partial_goal
sort_to_local_joint_order
validate_trajectory_msg
add_new_trajectory_msg

all used class variables, like dof_ and so on. I moved them to a separate file as proposed, and wrote additional unit tests.
I used the JTC-GPL-parameter struct as function arguments, but this makes these methods not really standalone without JTC.

  • Should I add all relevant fields directly and remove the struct as dependency?
  • Passing the logger and time to the methods seems a bit verbose, any suggestions?

The logic is almost identical, except for sort_to_local_joint_order where I also updated the joint_names field

 // might not be used any more, but to get a genuine msg
  trajectory_msg->joint_names = params.joints;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JTC] Cleanup TODO-List from #320
1 participant