-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JTC for hardware having offset from state measurements #189
Merged
bmagyar
merged 10 commits into
ros-controls:master
from
destogl:jtc-hw-state-has-offset
Jul 23, 2021
Merged
Enable JTC for hardware having offset from state measurements #189
bmagyar
merged 10 commits into
ros-controls:master
from
destogl:jtc-hw-state-has-offset
Jul 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-lopez
reviewed
May 28, 2021
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
destogl
commented
May 30, 2021
destogl
commented
May 30, 2021
…ing but separatelly. Is there some kind of timeout?
destogl
force-pushed
the
jtc-hw-state-has-offset
branch
from
June 25, 2021 09:52
c2f506c
to
13bd183
Compare
bmagyar
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nitpick, otherwise looks good to me!
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
v-lopez
approved these changes
Jul 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just minor comment that can be ignored.
joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp
Outdated
Show resolved
Hide resolved
bmagyar
added a commit
to destogl/ros2_controllers
that referenced
this pull request
Jul 28, 2021
…ntrols#189) * Avoid "jumps" with states that have tracking error. All test are passing but separatelly. Is there some kind of timeout? * Remove allow_integration_flag * Add reading from command interfaces when restarting controller * Rename variable according to review * Use even more clear name * Remove debug lines. * Update documentation * Apply suggestions from code review Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> * Move methods to cpp file as per reviewers comment. Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the first part of #161.
The goal is short: