Small fixes for JTC. #390
Merged
Small fixes for JTC. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bmagyar,
kasiceo,
malapatiravi,
progtologist and
rosterloh
|
This pull request is in conflict. Could you fix it @destogl? |
destogl
commented
Aug 6, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
destogl
commented
Aug 6, 2022
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
bmagyar
approved these changes
Aug 6, 2022
mamueluth
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Aug 26, 2022
variables in JTC to not clutter other PR with them. fixes of updating parameters on renewed configuration of JTC that were missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes for varialbes in JTC to not clutter other PR with them.
Also fixes of updating parameters on renewed configuration of JTC that were missed in #365.