Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Update coverage workflows and some cleanup #819

Merged
merged 6 commits into from
Nov 11, 2023
Merged

[CI] Update coverage workflows and some cleanup #819

merged 6 commits into from
Nov 11, 2023

Conversation

christophfroehlich
Copy link
Contributor

  • Add CI coverage jobs for humble and iron.
  • source build job missed all packages
  • I don't think we have to compile angles and generate_parameter_library for semi-binary jobs for humble+iron, angles even not for rolling.
  • Coverage jobs now build ros2_control from source. I haven't used the reusable_industrial_ci_with_cache action, was too complicated at the first glance 😇

christophfroehlich and others added 2 commits November 7, 2023 14:06
@christophfroehlich
Merge branch 'master' into update_coverage_ci
679aff8
@bmagyar @christophfroehlich
use humble job names
e98eef8 
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #819 (e98eef8) into master (2c6d7a6) will decrease coverage by 0.46%.
Report is 4 commits behind head on master.
The diff coverage is 27.27%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
- Coverage   45.29%   44.83%   -0.46%     
==========================================
  Files          40       40              
  Lines        3663     3649      -14     
  Branches     1730     1723       -7     
==========================================
- Hits         1659     1636      -23     
- Misses        821      834      +13     
+ Partials     1183     1179       -4
Flag Coverage Δ
unittests 44.83% <27.27%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 42.40% <27.27%> (-4.74%) ⬇️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit 232154d into ros-controls:master Nov 11, 2023
11 of 14 checks passed
@christophfroehlich christophfroehlich deleted the update_coverage_ci branch November 11, 2023 18:46
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Nov 11, 2023
mergify bot pushed a commit that referenced this pull request Nov 11, 2023
@christophfroehlich @mergify
[CI] Update coverage workflows and some cleanup (#819)
8cd7d61 
* Add CI coverage jobs for humble and iron

* Add all packages to source build

* Update repos files

* Build ros-control packages from source

* use humble job names

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

---------

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
(cherry picked from commit 232154d)

# Conflicts:
#	ros2_controllers.iron.repos
@mergify mergify bot mentioned this pull request Nov 11, 2023
Closed
mergify bot pushed a commit that referenced this pull request Nov 11, 2023
@christophfroehlich @mergify
[CI] Update coverage workflows and some cleanup (#819)
7c91cf5 
* Add CI coverage jobs for humble and iron

* Add all packages to source build

* Update repos files

* Build ros-control packages from source

* use humble job names

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

---------

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
(cherry picked from commit 232154d)
@mergify mergify bot mentioned this pull request Nov 11, 2023
Merged
@christophfroehlich christophfroehlich mentioned this pull request Nov 11, 2023
Merged
bmagyar pushed a commit that referenced this pull request Nov 12, 2023
@christophfroehlich
[CI] Codecov humble (backport #819) (#830)
6d75314
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 19, 2023
@christophfroehlich
Merge branch 'master' into jtc/controller_plugin
3e78665 
Squashed commit of the following:

commit 0a9f4b0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Nov 16 23:17:20 2023 +0000

    Bump ros-tooling/action-ros-ci from 0.3.4 to 0.3.5 (ros-controls#833)

commit 3fc0f50
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Wed Nov 15 20:03:40 2023 +0100

    [JTC] Activate update of dynamic parameters (ros-controls#761)

commit b13ae5b
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Wed Nov 15 19:14:09 2023 +0100

    [JTC] Fix tests when state offset is used (ros-controls#797)

    * Simplify initialization of states
    * Rename read_state_from_hardware method
    * Don't set state_desired in on_activate
    ---------

    Co-authored-by: Dr. Denis <denis@stoglrobotics.de>

commit f1a5397
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Wed Nov 15 12:18:38 2023 +0100

    [JTC] Remove deprecation warnings, set `allow_nonzero_velocity_at_trajectory_end` default false (ros-controls#834)

commit 232154d
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Sat Nov 11 15:30:19 2023 +0100

    [CI] Update coverage workflows and some cleanup (ros-controls#819)

    * Add CI coverage jobs for humble and iron

    * Add all packages to source build

    * Update repos files

    * Build ros-control packages from source

    * use humble job names

    Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>

    ---------

    Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>

commit 0196eeb
Author: Tony Baltovski <tony.baltovski@gmail.com>
Date:   Thu Nov 9 17:15:45 2023 -0500

    [diff_drive_controller] Fixed typos in diff_drive_controller_parameter.yaml. (ros-controls#822)

commit 71ec842
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Tue Nov 7 13:47:23 2023 +0100

    [CI] Re-add humble workflow files and add iron to readme (ros-controls#818)

commit 9d4ea6b
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Nov 7 12:01:23 2023 +0000

    [diff_drive_controller] Remove non-stamped Twist option (ros-controls#812)

commit 5f78fe4
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Nov 7 12:01:02 2023 +0000

    Adjust tests after passing URDF to controllers (ros-controls#817)

commit 2c6d7a6
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Mon Nov 6 18:29:10 2023 +0000

    Add iron branch (ros-controls#814)

commit f81a82c
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Fri Nov 3 21:18:31 2023 +0100

    [CI] Codecov  (ros-controls#807)

commit c6ecab7
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Wed Nov 1 21:38:16 2023 +0000

    Use pre-commit fork of clang-format instead of local (ros-controls#813)

commit 6e46053
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Oct 31 21:34:10 2023 +0000

    3.17.0

commit 822552f
Author: Bence Magyar <bence.magyar.robotics@gmail.com>
Date:   Tue Oct 31 21:33:40 2023 +0000

    Update changelogs

commit 8a90b51
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 31 20:27:04 2023 +0000

    Bump ros-tooling/action-ros-ci from 0.3.3 to 0.3.4 (ros-controls#810)

commit b65314d
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Thu Oct 26 12:09:27 2023 +0200

    Cleanup comments and unnecessary checks (ros-controls#803)

commit b36b9d2
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Tue Oct 24 20:17:28 2023 +0200

    [CI] Fix coverage build and codecov stats (ros-controls#804)

commit 22356e0
Author: Dr. Denis <denis@stoglrobotics.de>
Date:   Mon Oct 16 18:49:47 2023 +0200

    [TestNodes] Optimize output about setup of JTC publisher (ros-controls#792)

commit ac291ab
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Mon Oct 16 13:00:53 2023 +0200

    Steering controllers library: fix open loop mode (ros-controls#793)

    * set last*velocity variables for open loop odometry

    * Make function arguments const

    * Update function in header file too

commit c831b6c
Author: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Date:   Mon Oct 16 12:58:44 2023 +0200

    Update requirements of state interfaces (ros-controls#798)
bmagyar pushed a commit that referenced this pull request Nov 30, 2023
@mergify
[CI] Update coverage workflows and some cleanup (backport #819) (#828)
c859569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@anfemosa anfemosa Awaiting requested review from anfemosa

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@destogl destogl Awaiting requested review from destogl

@harderthan harderthan Awaiting requested review from harderthan

@homalozoa homalozoa Awaiting requested review from homalozoa

@VX792 VX792 Awaiting requested review from VX792

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophfroehlich @bmagyar