Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tf_prefix to the left_wheel_names and right_wheel_names to solve Gazebo plugin issue. #831

Closed
wants to merge 4 commits into from

Commits on Nov 13, 2023

  1. Added tf_prefix to the left_wheel_names and right_wheel_names.

    The tf prefix is added to the odom_frame_id and the base_frame_id. However, it is not done to the left_wheel_names and right_wheel_names.
    
    The differential drive controller is often used as a gazebo plugin like below. 
    ```
        <gazebo>
          <plugin filename="libgazebo_ros2_control.so" name="gazebo_ros2_control">
            <namespace>${robot_namespace}</namespace>
            <robot_param>robot_description</robot_param>
            <robot_param_node>robot_state_publisher</robot_param_node>
            <parameters>package://robot_description/config/robot_control.yaml</parameters>
          </plugin>
        </gazebo>
    ```
    
    Since this is defined inside a xacro, the Rewritten yaml cannot be used to add namespaces to joints. Adding the namespace in the cpp file bypasses this issue.  In the PR, the convention is followed. That is, "robot_namespace/left_wheel_name". Please let me know if I need to change it in any other place. The modified changes solves my issue and seems to run correctly on the Gazebo simulator.
    suchetanrs authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f3a8da0 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Configuration menu
    Copy the full SHA
    1c4167b View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Configuration menu
    Copy the full SHA
    86ee62e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9078dd0 View commit details
    Browse the repository at this point in the history