-
Notifications
You must be signed in to change notification settings - Fork 3
Add cast to boolean for cm_topic component #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit bb7c235.
|
I changed it to switch locally as pre request of @saikishor. An alternative to doing this in the framework ros-controls/ros2_control#2857 |
cm_topic_hardware_component/src/cm_topic_hardware_component.cpp
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=======================================
Coverage 78.45% 78.46%
=======================================
Files 6 6
Lines 441 455 +14
Branches 45 45
=======================================
+ Hits 346 357 +11
- Misses 66 69 +3
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| url: https://github.com/pal-robotics-forks/ros2_control.git | ||
| version: add/state_and_command_interface_handle_getters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| url: https://github.com/pal-robotics-forks/ros2_control.git | |
| version: add/state_and_command_interface_handle_getters | |
| url: https://github.com/ros-controls/ros2_control.git | |
| version: master |
MarqRazz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Maybe have a debug log for unsupported datatypes that way it's a little easier for people to see whats wrong without having to dig through the source code.
Bags recorded with ros-controls/ros2_control#2633 will fail now due to bad variant access.
Needs: ros-controls/ros2_control#2831