Skip to content

Conversation

@christophfroehlich
Copy link
Member

Handle types not being double are just not published now.

I tried to make cast_to_double() reusable, I did not find a better place to add it.

@christophfroehlich christophfroehlich added the backport-kilted Triggers PR backport to ROS 2 kilted. label Oct 7, 2025
* @throw std::runtime_error if the HandleDataType cannot be casted to double.
* @note Once we add support for more data types, this function should be updated
*/
double cast_to_double(const HANDLE_DATATYPE & value) const
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this good! We will also need this for reuse of controllers.

Also do backwards casting from double to internal values.

destogl
destogl previously approved these changes Nov 12, 2025
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this good!

saikishor
saikishor previously approved these changes Nov 23, 2025
@codecov
Copy link

codecov bot commented Nov 23, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.49%. Comparing base (30416ba) to head (af50a40).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...re_interface/include/hardware_interface/handle.hpp 71.42% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2633      +/-   ##
==========================================
- Coverage   89.62%   89.49%   -0.14%     
==========================================
  Files         152      152              
  Lines       17817    18021     +204     
  Branches     1455     1468      +13     
==========================================
+ Hits        15968    16127     +159     
- Misses       1263     1306      +43     
- Partials      586      588       +2     
Flag Coverage Δ
unittests 89.49% <90.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rface/include/hardware_interface/hardware_info.hpp 92.85% <100.00%> (+12.08%) ⬆️
hardware_interface/test/test_handle.cpp 98.68% <100.00%> (+0.16%) ⬆️
...ace_testing/test/test_components/test_actuator.cpp 88.73% <100.00%> (ø)
...re_interface/include/hardware_interface/handle.hpp 85.92% <71.42%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor marked this pull request as ready for review November 24, 2025 06:47
@christophfroehlich christophfroehlich merged commit fd12e90 into master Nov 24, 2025
17 checks passed
@christophfroehlich christophfroehlich deleted the publish/bool/pal_statistics branch November 24, 2025 17:55
mergify bot pushed a commit that referenced this pull request Nov 24, 2025
@saikishor
Copy link
Member

@christophfroehlich don't we want to backport this to Jazzy?

@christophfroehlich christophfroehlich added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Nov 24, 2025
mergify bot pushed a commit that referenced this pull request Nov 24, 2025
(cherry picked from commit fd12e90)

# Conflicts:
#	hardware_interface/include/hardware_interface/handle.hpp
#	hardware_interface/include/hardware_interface/hardware_info.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy. backport-kilted Triggers PR backport to ROS 2 kilted.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boolean data type signals are not shown in the data_introspection topic

4 participants