-
Notifications
You must be signed in to change notification settings - Fork 386
Publish all castable data types to pal_statistics #2633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| * @throw std::runtime_error if the HandleDataType cannot be casted to double. | ||
| * @note Once we add support for more data types, this function should be updated | ||
| */ | ||
| double cast_to_double(const HANDLE_DATATYPE & value) const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this good! We will also need this for reuse of controllers.
Also do backwards casting from double to internal values.
destogl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this good!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
- Coverage 89.62% 89.49% -0.14%
==========================================
Files 152 152
Lines 17817 18021 +204
Branches 1455 1468 +13
==========================================
+ Hits 15968 16127 +159
- Misses 1263 1306 +43
- Partials 586 588 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
(cherry picked from commit fd12e90)
|
@christophfroehlich don't we want to backport this to Jazzy? |
(cherry picked from commit fd12e90) # Conflicts: # hardware_interface/include/hardware_interface/handle.hpp # hardware_interface/include/hardware_interface/hardware_info.hpp
Handle types not being double are just not published now.
I tried to make cast_to_double() reusable, I did not find a better place to add it.