[ros2] allow cameras that do not support setting format options via VIDIOC_S_FMT #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benmaidel unfortunately I don't have hw that does not support setting the camera format to test on. Going to merge this anyways as I've tested it locally and this change does not seem to break any existing functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cameras, especially droidcam https://www.dev47apps.com/, do not support setting camera format parameters via v4l2 VIDIOC_S_FMT command. This changes will allow usage of this cameras if the selected pixelformat and width/height are the same as the camera supports.
This is a ros2 port of the PR #126. I have not tested it so far.