[ros2] add support for YUV420 (yu12) pixel format #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benmaidel fixed a small merge conflict after your other PR (#178 ) was merged. Unfortunately do not have any hw that supports this format but the changes look good to me and the changes do not affect any existing functionality |
|
@benmaidel this does add a new dependency on |
|
Since no one has objected to adding this dependency on |
|
I am holding off on merging this until someone can test it. Dont want to add these extra dependencies if it doesnt end up working out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ros2 port of the PR #125. I have not tested it so far.