Multiple cameras + compression

[brendoncintas]

I noticed that for the demo_launch, the support is mostly for one USB camera. I've modified the launch file to include other cameras, and remapped each image_raw and image_compressed topic to be on a per-camera basis rather than all of them being on one topic.

A note about this:

• This only works for ROS2.
• I've commented out the extra usb_cam nodes as I'll be needing 4 for my robot, but you can add or remove as needed.
• For my application, I didn't need the show_image.py script, so I removed it from the launch file. This could be added back if needed.

Also, I've cleaned up the code in the launch file to make each camera an individual node within a group, then launch the whole group with LaunchDescription, rather than each node being launched individually. Should make the code look a little cleaner.

FROM #247. I didn't PR the right branch. Whoops.

[flynneva]

@brendoncintas I like this idea of making it easier for users to launch multiple cameras at once. I've taken your branch and made one small improvement to it by making the config into a class that should make it dead simple for people to add new cameras to the launch file.

You can see the changes I made here.

To add new cameras to the launch file, now all that is needed is to add a few lines here that adds a new CameraConfig class to the list and thats it:

CameraConfig(
  name="camera1",
  param_path=Path(path, to, param file),
)

If you like them as well, then I can add them to this branch I think and we can go ahead with this PR.

Let me know what you think!

[brendoncintas]

@brendoncintas I like this idea of making it easier for users to launch multiple cameras at once. I've taken your branch and made one small improvement to it by making the config into a class that should make it dead simple for people to add new cameras to the launch file.

You can see the changes I made here.

To add new cameras to the launch file, now all that is needed is to add a few lines here that adds a new CameraConfig class to the list and thats it:

CameraConfig(
  name="camera1",
  param_path=Path(path, to, param file),
)

If you like them as well, then I can add them to this branch I think and we can go ahead with this PR.

Let me know what you think!

That is an incredible idea, and I'm all for it. Go ahead and add them to the branch and go ahead with the PR.

[brendoncintas]

This should be good to go!

[flynneva]

@brendoncintas thanks, I cleaned up the commits and fixed the linter errors. Lets wait for CI to run again as it should pass now

[flynneva]

@brendoncintas thanks for the contribution! 🙏🏼

[brendoncintas]

Glad to have been a part of it!