Fixed wrong image timestamp due to missing handling of microseconds in epoch time shift #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n epoch time shift.
flynneva
approved these changes
Jul 22, 2023
|
@boitumeloruf thanks for the contribution 🙏🏼 |
This was referenced Jul 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, in the calculation of the epoch time shift the offset was rounded to seconds and, thus, cutting off a shift in milli- and microseconds. This would be fine if the v4l2 buffer timestamp would be synced to the wall time on the bases of seconds. But this is not the case and, thus, the subsequent calculation of the image timestamp was wrong since the sub-second shift was missing.
I corrected this by computing the epoch time shift in microseconds (which is the smallest unit of
epoch_timein the type oftimeval. Then in the calculation of the image timestamp, the buffer time is first converted into microseconds before the epoch time shift is added. Afterwards, it is split into seconds and nanoseconds for the image timestamp.This PR implicitly PR #261. And I think this also resolves the issue #259 .