Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mjpeg invalid ptr and mjpeg memory leak #279

Merged
merged 4 commits into from
Aug 31, 2023

Conversation

flynneva
Copy link
Collaborator

@flynneva flynneva commented Aug 22, 2023

Closes #274
Closes #275
Closes #277

Closes ros-drivers#274 ros-drivers#275

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
Closes ros-drivers#277

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
Relates to ros-drivers#262

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@TZECHIN6
Copy link

TZECHIN6 commented Aug 22, 2023

Screenshot from 2023-08-22 13-41-16

I have tested the fix, so far the camera can be launched for couple minutes and no crashing.

However as you can see from the image, the decoder seem not well functioning.... not sure is it caused by my hardware (video stream is fine, but there is noise)

@flynneva
Copy link
Collaborator Author

@TZECHIN6 is anything printed to the console?

I'll take a look at this again over the weekend but any more info you can give would help me track this down!

@TZECHIN6
Copy link

@TZECHIN6 is anything printed to the console?

I'll take a look at this again over the weekend but any more info you can give would help me track this down!

Screenshot from 2023-08-25 15-51-03

Sadly the console looks normal... might be others could help check this with their own cable and camera?

Signed-off-by: Evan Flynn <evanflynn.msu@gmail.com>
@flynneva
Copy link
Collaborator Author

@TZECHIN6 could you possibly try one more time? For my MJPEG camera the image looks OK...so I am not quite sure what the issue for yours is.

If its still an issue for you - could you spin it out into another follow-up issue and we can tackle it with a separate PR.

@flynneva flynneva changed the title Fix mjpeg invalid ptr Fix mjpeg invalid ptr and mjpeg memory leak Aug 31, 2023
@flynneva flynneva merged commit ec67cb2 into ros-drivers:ros2 Aug 31, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants