Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #89: make package name consistent with directory name #117

Merged
merged 1 commit into from
Aug 25, 2016
Merged

Fix for issue #89: make package name consistent with directory name #117

merged 1 commit into from
Aug 25, 2016

Conversation

gavanderhoorn
Copy link
Member

As per subject.

See #89 for discussion.

@gavanderhoorn
Copy link
Member Author

Note that Travis will fail, as #116 has not been merged yet.

@gavanderhoorn
Copy link
Member Author

Rebased, and now that #116 has been merged Travis is also happy.

@gavanderhoorn
Copy link
Member Author

@Levi-Armstrong: could you vet this one as well?

@Levi-Armstrong
Copy link
Contributor

+1

@Levi-Armstrong Levi-Armstrong merged commit b3fb17f into ros-industrial-attic:m1_merge_candidate_v2 Aug 25, 2016
@Levi-Armstrong Levi-Armstrong deleted the pkg_rename branch August 25, 2016 14:03
@gavanderhoorn
Copy link
Member Author

Thanks for merging, but would you please not delete branches on my personal clone? :)

@Levi-Armstrong
Copy link
Contributor

Oops sorry, did it out of habit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gavanderhoorn @Levi-Armstrong