Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planned migration of abb_driver to its own repository #179

Closed
8 tasks done
gavanderhoorn opened this issue Apr 5, 2020 · 4 comments
Closed
8 tasks done

Planned migration of abb_driver to its own repository #179

gavanderhoorn opened this issue Apr 5, 2020 · 4 comments
Assignees

Comments

@gavanderhoorn
Copy link
Member

gavanderhoorn commented Apr 5, 2020

As a consequence of the consensus reached in ros-industrial/ros_industrial_issues#49, I've extracted abb_driver out of this repository and have created a new repository that hosts just the driver. You may find the candidate at ros-industrial/abb_driver.

NOTE: this is not the final version. Things may still change.

I've tried to retain as much of the commit history as possible (and where it made sense), and will transfer any open issues as well.

Commits and file provenance have been retained, and references to issues and PRs have been updated wherever possible. Only the kinetic-devel branch will be created -- others can still be found here, in ros-industrial/abb. Of course all commits are part of the new repository, we'll just not recreate all the labels.

To give current users sufficient time to update their remotes and/or not disturb running processes, abb_driver will be removed from ros-industrial/abb in two weeks (ie: on 2020-04-19).

Further tasks to complete the migration:

@gavanderhoorn
Copy link
Member Author

gavanderhoorn commented Apr 22, 2020

Not going to create a .rosinstall file, as it should not be needed: as soon as abb_driver has been released again, rosdep should be able to resolve it and it should be installed automatically.

As abb_driver is not needed for a from-source build of ros-industrial/abb (it's only an exec_depend), this would seem to remove the need to facilitate source builds with a .rosinstall file.

With the same rationale, we're not going to update the Travis configuration (as that's essentially a from-source build but then as part of CI).

gavanderhoorn added a commit to gavanderhoorn/abb that referenced this issue Apr 22, 2020
Migrated to 'ros-industrial/abb_driver'.

Ref: ros-industrial#179.
This was referenced Apr 22, 2020
@gavanderhoorn gavanderhoorn self-assigned this Apr 23, 2020
@gavanderhoorn
Copy link
Member Author

gavanderhoorn commented Apr 25, 2020

abb_driver has been removed (#180), readme updated (#181).

Only thing remaining is to release it again from the new repository.

Until that time, abb_driver will be built from the already released source tarball, so nothing will break, even without releasing it from the new location.

We'll keep this issue open until abb_driver has been released from it's new location.

@gavanderhoorn
Copy link
Member Author

abb_driver released into Kinetic and Melodic (see OP for links to rosdistro PRs).

I'll close this once those PRs have been merged.

@gavanderhoorn
Copy link
Member Author

Both PRs have been merged.

Pending an issue with the buildfarm (this one), abb_driver will be built from its new location and be available similar to how it was available when it was still part of ros-industrial/abb.

As this completes the migration, I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant