-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WiP] Fix upstream downstream package logic #137
[WiP] Fix upstream downstream package logic #137
Conversation
28f4ee7
to
1155382
Compare
For some reasons the actionlib tests fail. |
Tested this together with @ipa-mdl on branch ipa320/cob_robots#626 |
1155382
to
8dc89f7
Compare
I have rebased to current master and updated the logic.
|
a4a6d6e
to
a1caec5
Compare
The latest update improved the handling of export and test depends. @ipa-fxm: please test again. On my laptop the full run of the kinetic build/test takes 20 minutes. |
See my ipa320/cob_robots#626 (comment)... |
5c7cc0d
to
b8676af
Compare
f6baab0
to
ef29214
Compare
The same technique could be used for prerelease tests (#145) |
ef29214
to
82135b0
Compare
rebased on top of #150 |
82135b0
to
cfb7f17
Compare
cfb7f17
to
966a5e2
Compare
rebased to current master, works with |
opt-out with STRICT_TEST_DEPENDS=true
5a03b2b
to
c311617
Compare
relaxed mode is default, strict mode can be enabled with |
as discussed with @ipa-fxm downstream packages should not get detected automatically |
6f168e4
to
3d1d013
Compare
having fixed our issue with the travis log length in #267, I would also like to see our travis build time reduced what is the status of this feature/pr? @ipa-mdl |
I'm also interested in this feature. |
Not in this form. I think we can migrate some of it to our current codebase. For the actual upstream/downstream detection I would rather use some interfaces of catkin-tools directly instead of my custom code. |
Proper handling of upstream and downstream workspaces is implemented in #361 |
addresses #106
some unrelated minor fixes are bundled as well:
build to install space (Consider building to install space directly #54)(build directly to install space #150)The dependency helper covers most of the designed logic, but uses a consolidated rosdep install step for now.
It detects the target and downsteam packages automatically, if these are not provided.
The detection can be filtered by
BUILD_PKGS_WHITELIST
andBUILD_PKGS_BLACKLIST
(new).The upstream packages cannot be black- or whitelisted.
Based on all upstream, target and downstream packages the list of rosdep src paths gets compiled.
In addtion the list of tests gets generated and can be filtered with
TEST_BLACKLIST
(new).The resulting package list gets printed outside of the folds, including the ignores packages.
As unrelated packages get irgnored now, the travis jobs had to be extended to enforce the downstream packages.
All steps are run in separated folds, so failures can be attributed more easily.
I took the chance to fix #118
(The list of commits is a little bit mixed up - sorted by date instead of relation - in the PR display because of the rebases)
TODO:
deps.py
a proper moduledeps.py