Use latest prerelease features #145
Conversation
|
New test case 9: https://travis-ci.org/ros-industrial/industrial_ci/jobs/211869139 |
mathias-luedtke
force-pushed
the
enhancement/prerelease-updates
branch
from
2b5b72f
to
1383180
Compare
mathias-luedtke
force-pushed
the
enhancement/prerelease-updates
branch
from
3f0a9b0
to
a796590
Compare
|
|
mathias-luedtke
changed the title
mathias-luedtke
force-pushed
the
enhancement/prerelease-updates
branch
4 times, most recently
from
2e9c72a
to
02f4c4f
Compare
|
Will try looking into this over the weekend! |
mathias-luedtke
force-pushed
the
enhancement/prerelease-updates
branch
from
02f4c4f
to
80b19a8
Compare
mathias-luedtke
force-pushed
the
enhancement/prerelease-updates
branch
from
80b19a8
to
3a82d5e
Compare
There was a problem hiding this comment.
This looks great! Added test jobs seem to be working nicely too. I left some comments inline.
Btw just curious, the fold in the fold (e.g. this) is what's added in industrial_ci or does it come from somewhere upstrem? That's nice too (if only it could be colorized when error occurs inside, since finding errors may be a bit tricky without it. But may not be a big deal).
doc/index.rst
Outdated
| * `PRERELEASE_REPONAME` (default: not set): The target of Prerelease Test (that you select at `<http://prerelease.ros.org/indigo>`_, `<http://prerelease.ros.org/kinetic>`_ etc.). | ||
| * If not set then it tests the package of the repository's name. You can specify this by your ROS package name format (with underscore e.g. `industrial_core`), not Debian package name format. NOTE that this package name must be listed in the `rosdistro/distribution.yaml` (e.g. [for ROS Indigo](https://github.com/ros/rosdistro/blob/master/indigo/distribution.yaml)) (this requirement comes from ROS buildfarm's Prerelease Test). | ||
| * (As of Dec 2016) when this variable is set, development branch listed in `rosdistro/distribution.yaml` is tested. See [detail](https://github.com/ros-industrial/industrial_ci/pull/85#issue-196409011). | ||
| * `PRERELEASE_REPONAME` (default: TARGET_REPO_NAME): The name of the target of Prerelease Test in rosdistro (that you select at `<http://prerelease.ros.org>`_). You can specify this if your repository name differs from the corresponding rosdisto entry. |
There was a problem hiding this comment.
You can specify this if your repository name differs from the corresponding rosdisto entry.
This is a bit unclear. Readers may want to know, in which cases specifying different name here could be useful, if the name specified is different from the tested repo name, where is the specified package retrieved from? etc.
There was a problem hiding this comment.
It does not get retrieved. It is just the name in rosdistro.
E.g. if your key in rosdistro is my_pkg and for some reason your source is in https://github.com/me/my_pkg_impl.git, you have to set PRERELEASE_REPONAME=my_pkg.
I guess this case is prettry rare.
There was a problem hiding this comment.
I see. That usecase is a good example. We should add it to the doc or at least link here. Please review mathias-luedtke#8
| run_in_prerelease_docker catkin_test_results $WORKSPACE/catkin_workspace_overlay/test_results | ||
| ici_time_end # prerelease_build_overlay.sh | ||
| fi | ||
| run_in_prerelease_docker generate_prerelease_script.py https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml "$ROS_DISTRO" default ubuntu "$UBUNTU_OS_CODE_NAME" amd64 --level "$downstream_depth" --output-dir . --custom-repo "$reponame::::" |
There was a problem hiding this comment.
"$reponame::::"
Just curious, are the trailing colons still needed?
There was a problem hiding this comment.
Yes, all of them.
repo : type : url_scheme : url_path : branch
For us type, url_scheme, url_patch, branch are empty.
This way the prerelease will fail if the target source code is missing.
| @@ -26,8 +26,9 @@ env: | |||
| - ROS_DISTRO=indigo NOT_TEST_BUILD='true' NOT_TEST_INSTALL='true' POST_PROCESS='I_am_supposed_to_fail' | |||
| - ROS_DISTRO=indigo CATKIN_PARALLEL_JOBS='-p1' ROS_PARALLEL_JOBS='-j1' # Intend build on low-power platform | |||
| # - env: ROS_DISTRO=indigo PRERELEASE=true ## Comment out because this is meaningless for always failing without prerelease testable contents in industrial_ci. | |||
| - ROS_DISTRO=indigo PRERELEASE=true PRERELEASE_REPONAME=std_msgs PRERELEASE_DOWNSTREAM_DEPTH=0 | |||
| - ROS_DISTRO=kinetic PRERELEASE=true PRERELEASE_REPONAME=std_msgs | |||
| - ROS_DISTRO=indigo PRERELEASE=true PRERELEASE_DOWNSTREAM_DEPTH=1 | |||
There was a problem hiding this comment.
Don't we (also) want to add a job for a package that is actually depended on by maybe just one or a few packages so that we can test PRERELEASE_DOWNSTREAM_DEPTH? We can even add another package to mockups and inject dependency.
There was a problem hiding this comment.
This is not possible for now. With this patch, we cannot "fake" the identity anymore, and industrial_ci does not have any dowstream depencies.
In a later versions we might add a full rosinstall workspace as underlay, then we can test it again
There was a problem hiding this comment.
So I assume this new job does not test anything distinct for now other than testing PRERELEASE_DOWNSTREAM_DEPTH option to not cause error.
PRERELEASE_REPONAMEThe latter prevents testing packages other than the target repo as we did it before.