-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two Arms and Rail With DX100 #179
base: kinetic-devel
Are you sure you want to change the base?
Two Arms and Rail With DX100 #179
Conversation
…t prevents the system from correctly interpreting joint states that do not feature 4 control groups.
… of jettan's motoman driver.
Related PR: #89 (comments). |
@Jmeyer1292 are you still working on this one? |
Yes - I should have time next week. The additional changes I want to make are fairly minimal. Mostly adding an example to the DX100 Inform code and addressing a couple of small things I changed regarding publishers in the code. I don't know how we go about validating hardware... I want to test on a single arm configuration. Our SIA20D is unfortunately tied up for the rest of time, but I should be able to run it on the robot on Euler. |
@Jmeyer1292 wrote:
be sure to check #183 and the example |
@gavanderhoorn Good call, those new jobs look very familiar. Major props to @ted-miller for his support - thanks! |
Sorry guys...digging back through these. Is this PR good to merge? |
I don't know about @Jmeyer1292's commits, but the changes he copied from the branches we used for the APC could perhaps use some work. I keep postponing reimplementing them though. |
I shouldn't have made this PR because I'm not prepared to support it at this time. Closing. |
@Jmeyer1292: we could keep it open as a reminder of the things that need to be fixed. It's also a 'nice' entrypoint for users that want to use |
Re-opening just to keep this on the radar. These fixes are needed. |
These changes reflect the driver side changes that had to be made to support my 6-DOF motoman w/ an external rail.
This is not ready for merging
Please note that:
I'm creating this so I have some documentation of the effort I went through.
I anticipate further cleanups will be desired, as well as testing on single arm, multi arms configs.