Remove stomp_core package and leverage stomp cmake package #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Levi-Armstrong
force-pushed
the
update/RemoveStompCore
branch
from
e5b5370
to
e93f5bd
Compare
|
Thanks for creating this PR, I'll review it tomorrow |
|
@Levi-Armstrong this looks good to me, did you build this in melodic or noetic? It may make sense to create a noetic-devel branch and merge these changes there instead |
|
@jrgnicho Did you want to merge this into this branch? |
|
@Levi-Armstrong let me make sure that the moveit repository isn't currently using the melodic devel branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stomp_core package has been moved to the stomp repository which is now independent of ROS.
It has also been renamed to stomp instead of stomp_core because the core is redundant.