-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ur_kinematics #453
Update ur_kinematics #453
Conversation
…within limits instead of the 8 original ones
The pybind11 submodule is now fetched via https instead of ssh
Disabled unit tests for ur_kinematics by default
First: thank you for the PR and the work, this looks like a good improvement. Three initial comments:
|
Apparently there is a Catkin-wrapped version of |
Starting with Bionic we could depend on ros/rosdistro#22261. |
I'm having issues using the kinematics plugin for a UR5e. Specifically, it seems the included Is this something anyone else has encountered? |
Summary
ur_kinematics
can only support one UR robot type without being recompiled and uses old style C++ code. Moreover the python bindings are not functional. It also doesn't support the e-series robots. In this PR, we aim at modernizing this package, fixing those 3 issues.Details
Here is what was done:
Warning
Since robot parameters are handled at run-time instead of compile time, a small over-head occurs reducing the time performances by a few percents. However, with C++20 we could remove said over head with the addition of class types in non-type template parameters
Related issue : #442