Skip to content

Commit

Permalink
Switch rolling sync threshold from count to required packages. (#175)
Browse files Browse the repository at this point in the history
* Switch rolling sync threshold from count to required packages.

For most ROS distributions we want to periodically ratchet up the
package count for sync thresholds. However Rolling is meant to be
somewhat volatile as large changes are made.

A large enough number of ancillary packages have been introduced to
Rolling that the "base" numeric package count is no longer sufficient to
guarantee the presence of ROS core packages. So let's instead use the
required packages sync criteria and require the presence of ros_desktop
which will in turn require the ROS core and a relatively healthy ROS
system to be available.

* Keep a minimum package count as well as required packages.

Co-authored-by: Tully Foote <tfoote@osrfoundation.org>

* Add package count requirements for other release configurations.

Co-authored-by: Tully Foote <tfoote@osrfoundation.org>
  • Loading branch information
nuclearsandwich and tfoote authored Aug 4, 2021
1 parent 24cfd08 commit 87a0d54
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion rolling/release-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ notifications:
- ros2-buildfarm-rolling@googlegroups.com
maintainers: true
sync:
package_count: 262
package_count: 500
packages: [desktop]
repositories:
keys:
- |
Expand Down
3 changes: 2 additions & 1 deletion rolling/release-focal-arm64-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ notifications:
- ros2-buildfarm-rolling@googlegroups.com
maintainers: true
sync:
package_count: 262
package_count: 500
packages: [desktop]
repositories:
keys:
- |
Expand Down
3 changes: 2 additions & 1 deletion rolling/release-rhel-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ package_ignore_list:
- rosidl_typesupport_gurumdds_cpp # No RPM package for GurumDDS
- rti_connext_dds_cmake_module # No RPM package for Connext
sync:
package_count: 262
package_count: 400
packages: [desktop]
repositories:
keys:
- |
Expand Down

0 comments on commit 87a0d54

Please sign in to comment.