Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adding slam toolbox to arm 64 buster blacklist" #175

Merged

Conversation

SteveMacenski
Copy link

Reverts #173

Re-adds slam toolbox for ARM builds due to libceres.

@dirk-thomas
Copy link
Member

@sloretz Friendly ping.

@sloretz sloretz merged commit be24d0a into ros-infrastructure:production Jul 16, 2020
@SteveMacenski
Copy link
Author

SteveMacenski commented Jul 20, 2020

http://build.ros.org/job/Nbin_dbv8_dBv8__slam_toolbox__debian_buster_arm64__binary/14/console it looks like Buster libceres was not updated like it was for ARM though I see it https://packages.debian.org/buster/libceres-dev

@sloretz should I readd to the not-building list or is this a sync fluke that will self right in a bit? There's no Cartographer on Noetic yet.

SteveMacenski added a commit to SteveMacenski/ros_buildfarm_config that referenced this pull request Jul 20, 2020
sloretz pushed a commit that referenced this pull request Jul 20, 2020
nuclearsandwich referenced this pull request in ros2/ros_buildfarm_config Dec 28, 2020
nuclearsandwich referenced this pull request in ros2/ros_buildfarm_config Dec 28, 2020
nuclearsandwich added a commit that referenced this pull request Aug 4, 2021
* Switch rolling sync threshold from count to required packages.

For most ROS distributions we want to periodically ratchet up the
package count for sync thresholds. However Rolling is meant to be
somewhat volatile as large changes are made.

A large enough number of ancillary packages have been introduced to
Rolling that the "base" numeric package count is no longer sufficient to
guarantee the presence of ROS core packages. So let's instead use the
required packages sync criteria and require the presence of ros_desktop
which will in turn require the ROS core and a relatively healthy ROS
system to be available.

* Keep a minimum package count as well as required packages.

Co-authored-by: Tully Foote <tfoote@osrfoundation.org>

* Add package count requirements for other release configurations.

Co-authored-by: Tully Foote <tfoote@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants