Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mppic docs #378

Merged
merged 3 commits into from
Dec 22, 2022
Merged

adding mppic docs #378

merged 3 commits into from
Dec 22, 2022

Conversation

SteveMacenski
Copy link
Member

No description provided.

@SteveMacenski SteveMacenski merged commit 33d680c into master Dec 22, 2022
@SteveMacenski SteveMacenski deleted the mpppc branch December 22, 2022 00:06
@@ -92,6 +92,10 @@ Controllers
| | | variation on the pure pursuit | Differential |
| | | algorithm with adaptive features.| |
+----------------------------+--------------------+----------------------------------+-----------------------+
| `MPPI Controller`_ | Steve Macenski | A predictive MPC controller with | Differential, Omni, |
Copy link
Member

@padhupradheep padhupradheep Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A predictive MPC controller

Hmm.. sounds a bit off, because it is like when you expand, it is predictive Model Predictive Controller.. maybe we could just abbreviate MPC ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR is always appreciated 😉

This is mostly stream of consciousness. Better to have something than nothing is my documentation motto

offset_from_furthest: 4
threshold_to_consider: 0.40
max_angle_to_furthest: 1.0
# TwirlingCritic:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to explain it below, why this is commented?

Also, I cannot find anywhere what this specific critic does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its commented out mostly because that's how its in my file 😉 I wanted the example to be complete (e.g. have all of the critics) but not necessarily the ones that are not enabled by default. It provides some context.

But this penalizes twirling motions - e.g. unnecessary rotations. It could potentially also help with maybe some of the angular velocity jitter, but its main goal is to add a small penalty so that omnidirectional robots don't start drifting in different rotational axes while moving. It discourages excessive rotations so you don't end up with a moving forward while also rotating a bit clockwise (because why not otherwise?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants