Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce time it takes to process NavigateToPose request #1516

Closed
Jconn opened this issue Feb 11, 2020 · 7 comments
Closed

reduce time it takes to process NavigateToPose request #1516

Jconn opened this issue Feb 11, 2020 · 7 comments

Comments

@Jconn
Copy link
Contributor

Jconn commented Feb 11, 2020

merging in #1515 adds another 200-300ms of latency to handling a NavigateToPose request, which is a lot.

This comes from creating a new behavior tree every time a NavigateToPose request is accepted. That change is done to handle CoroActionNode's properly. But there should be a smarter way that doesn't take so much time.

@SteveMacenski
Copy link
Member

Did you file a ticket with BehaviorTree.CPP on the reset?

@Jconn
Copy link
Contributor Author

Jconn commented Feb 15, 2020

it is here BehaviorTree/BehaviorTree.CPP#146

@SteveMacenski
Copy link
Member

Awesome, thanks for linking it.

Is this ticket something you have a a business reason to look into, or should I put this in the pool of tasks to try to find some interested parties to look at?

@Jconn
Copy link
Contributor Author

Jconn commented Feb 15, 2020

I would put it in the pool - we aren't prioritizing performance issues yet

@SteveMacenski
Copy link
Member

Ok, thanks for the update.

@facontidavide
Copy link
Contributor

Hi,

I probably need to join this. I am sorry that my library is creating issues of this kind. I will try to dedicate time to this in the next days.

@SteveMacenski
Copy link
Member

#1606 resolves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants