Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate changing branch to line code coverage #1709

Closed
SteveMacenski opened this issue May 8, 2020 · 1 comment
Closed

Investigate changing branch to line code coverage #1709

SteveMacenski opened this issue May 8, 2020 · 1 comment

Comments

@SteveMacenski
Copy link
Member

The OSRF Quality level 1 target for coverage of 90% is line coverage not branch coverage.

Currently, our test coverage is branch coverage, which is why it looks very low (well, its definitely not 90% either). Many functions in the C++ standard library can throw exceptions when used incorrectly. Those exceptions stop lines which are functionally covered in all branches of the code to show up as only partially covered because we would have to trigger every single exception possible for every single line (dozens if not hundreds).

We have main() functions with no branching statements with < 30% coverage because rclcpp::init can throw exceptions, vector push_back can throw exceptions, even string additions.

I'd love a PR to change branch coverage to line coverage to analyze the results and help make a final call about which we should be tracking.

@SteveMacenski
Copy link
Member Author

Investigated and discussion in details in #1713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant