Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start not included in SmacPlanner path #3085

Closed
mangoschorle opened this issue Jul 22, 2022 · 1 comment
Closed

Start not included in SmacPlanner path #3085

mangoschorle opened this issue Jul 22, 2022 · 1 comment
Labels
good first issue Good for newcomers

Comments

@mangoschorle
Copy link

The path returned by smac planner doesn't explicitly include the start.

bool NodeHybrid::backtracePath(CoordinateVector & path will not add the start node (who's parrent I would assume is a nullptr). Whats the reasoning not to include the start. Is this on purpose or should there be a do while loop.

https://github.com/ros-planning/navigation2/blob/97068787fb35894a098f9c4600b5a06c7dddf43b/nav2_smac_planner/src/node_hybrid.cpp#L700

@SteveMacenski
Copy link
Member

SteveMacenski commented Jul 22, 2022

That was likely an oversight. Feel free to submit a PR and I'd be happy to merge it. Its likely that all 3 planners have this issue, so fixing them across the board would be appreciated (esp. given the trivial nature of the fix).

@SteveMacenski SteveMacenski added the good first issue Good for newcomers label Aug 19, 2022
@jwallace42 jwallace42 mentioned this issue Sep 2, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants