Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Deprecated CMAKE_COMPILER_IS_GNUCXX variable #3646

Closed
Ryanf55 opened this issue Jun 22, 2023 · 2 comments · Fixed by #3662
Closed

CMake: Deprecated CMAKE_COMPILER_IS_GNUCXX variable #3646

Ryanf55 opened this issue Jun 22, 2023 · 2 comments · Fixed by #3662
Labels
in progress

Comments

@Ryanf55
Copy link
Contributor

Ryanf55 commented Jun 22, 2023

Bug report

Required Info:

  • Operating System:
    • Ubuntu 22.04
  • ROS2 Version:
    • Rolling
  • Version or commit hash:
    • N/A

Steps to reproduce issue

Just reading the NAV2 CMake source code and NAV2 source code, this variable is deprecated:

https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILER_IS_GNUCXX.html

Expected behavior

Using non-deprecated CMake

Actual behavior

NAV2 is using deprecated variables

Additional information

This should be a quick swap.
@SteveMacenski
Copy link
Member

SteveMacenski commented Jun 22, 2023 •
edited
Loading

A PR would be appreciated 😄

In the future for things like this that are one-liner changes, you can just submit a PR with this context. No need for a ticket.

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Jun 22, 2023

You got it

@SteveMacenski SteveMacenski mentioned this issue Jun 27, 2023
Merged
@SteveMacenski SteveMacenski linked a pull request Jun 27, 2023 that will close this issue
Resolves 3646: Update CMAKE_COMPILER_IS_GNUCXX #3662
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves 3646: Update CMAKE_COMPILER_IS_GNUCXX ros-navigation/navigation2
2 participants
@SteveMacenski @Ryanf55