-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set size_x_ and size_y_ in method initMaps #4014
Comments
All uses of it now either call it using the member sizes or set the new member sizes right before the call (e.g. resizeMap). You could do the same in your application of just setting those member sizes before you call |
7 tasks
Already submitted a PR |
I requested a quick change, otherwise LGTM |
Done, please notice the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Required Info:
Steps to reproduce issue
in file costmap_2d.cpp
Expected behavior
Actual behavior
Additional information
Feature request
Feature description
set size_x_ and size_y_ in this method. Since these two attributes are always used to describe costmap_, I think this information should be synchronized when initializing the map, and setting them separately causes code redundancy.
Implementation considerations
The text was updated successfully, but these errors were encountered: