Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collision Monitor parameters on ROS2 Humble #4612

Closed
EnzoGhisoni opened this issue Aug 9, 2024 · 4 comments
Closed

Collision Monitor parameters on ROS2 Humble #4612

EnzoGhisoni opened this issue Aug 9, 2024 · 4 comments

Comments

@EnzoGhisoni
Copy link

Required Info:

  • Operating System:
    Ubuntu 22.04

  • ROS2 Version:
    ROS2 Humble

  • Version or commit hash:
    nav2 1.1.15

Feature request

We are working with a collision_monitor on our robot. According to the nav2 documentation the parameters .enabled and <polygon_name name>.enabled are supposed to be dynamic but they are not available on ROS2 humble (but are implemented for Iron and Jazzy). We would like to avoid the ROS2 version to Iron (EOL) and Jazzy (Ubuntu 22.04).
Is a port of this feature planned for ROS2 Humble?

@SteveMacenski
Copy link
Member

Can you find the commit that it was introduced? It may be API/ABI incompatible and thus not backportable. If it is backportable, then I'd be happy to have a PR that backports to Humble so you can use it!

@EnzoGhisoni
Copy link
Author

Here is the pull request where the parameter has been introduced: #3825 and it seems to be the commit c2d84dfe671077bd76781ea356141b6d7ebb86f4

@EnzoGhisoni
Copy link
Author

I will try to send a pull request to add these features, at first look the changes seem to be backportable.

@SteveMacenski
Copy link
Member

Great! I took a look and it looks good to me. Lets continue the discussion in that PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants