Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter failures in nav2_dwa_controller #72

Closed
crdelsey opened this issue Sep 7, 2018 · 0 comments
Closed

Fix linter failures in nav2_dwa_controller #72

crdelsey opened this issue Sep 7, 2018 · 0 comments
Labels
bug Something isn't working
Milestone
September 2018

Comments

@crdelsey
Copy link
Contributor

crdelsey commented Sep 7, 2018

Test project /home/crdelsey/src/ros_dev_workspace/navigation2/build/nav2_dwa_controller
Start 1: copyright
1/5 Test #1: copyright ........................ Passed 0.46 sec
Start 2: cppcheck
2/5 Test #2: cppcheck ......................... Passed 0.46 sec
Start 3: cpplint
3/5 Test #3: cpplint .......................... Passed 0.49 sec
Start 4: lint_cmake
4/5 Test #4: lint_cmake .......................***Failed 0.45 sec
Start 5: uncrustify
5/5 Test #5: uncrustify ....................... Passed 0.47 sec

80% tests passed, 1 tests failed out of 5
@mkhansenbot mkhansenbot added the bug Something isn't working label Sep 17, 2018
@mkhansenbot mkhansenbot added this to the September 2018 milestone Sep 17, 2018
This was referenced Sep 25, 2018
Merged
Merged
ghost referenced this issue in logivations/navigation2 Mar 7, 2022
@rdeniza @liyuanlogi
Move lidar check for pallet pickup to BT (#72)
5e28956 
* lift the pallet inside the BT

* remove lidar_field double check

* check lidar_field is in 2 or 3 for at least 2 seconds

* use <Delay> instead of <Wait> between lidar checks

* remove extra <isLidarTriggered>

* add TODO to remove checking LIDAR trigger_field=3

Co-authored-by: liyuanlogi <72910335+liyuanlogi@users.noreply.github.com>
Co-authored-by: liyuanlogi <li-yuan.hsu@logivations.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
2 participants
@mkhansenbot @crdelsey