[humble] image_publisher: Fix image constantly flipping when static image is published #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kotochleb
changed the title
ahcorde
requested changes
May 27, 2024
Kotochleb
force-pushed
the
buffix/image-publisher-flipping-image
branch
from
510cb0a to
2a662bd
Compare
Kotochleb
force-pushed
the
buffix/image-publisher-flipping-image
branch
from
2a662bd to
a87b971
Compare
ahcorde
pushed a commit
that referenced
this pull request
May 27, 2024
… image is published (#986) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
… image is published (#986) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 7f25ec9)
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
… image is published (#986) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 7f25ec9)
mergify bot
pushed a commit
that referenced
this pull request
May 27, 2024
… image is published (#986) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`. (cherry picked from commit 7f25ec9)
This was referenced May 27, 2024
Merged
Merged
ahcorde
pushed a commit
that referenced
this pull request
May 27, 2024
… image is published (backport #986) (#989) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #986 done by [Mergify](https://mergify.com). Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com>
ahcorde
added a commit
that referenced
this pull request
May 27, 2024
…published (backport #986) (#988) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #986 done by [Mergify](https://mergify.com). Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
mikeferguson
pushed a commit
that referenced
this pull request
Jun 10, 2024
…published (backport #986) (#987) Continuation of #984. When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time `ImagePublisher::doWork()` was called, resulting in the published image being flipped back and forth all the time. This PR should be straightforward to port it to `Humble`, `Iron` and `Jazzy`.<hr>This is an automatic backport of pull request #986 done by [Mergify](https://mergify.com). Co-authored-by: Krzysztof Wojciechowski <49921081+Kotochleb@users.noreply.github.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When publishing video stream from a camera, the image was flipped correctly. Yet for a static image, which was loaded once, the flip function was applied every time
ImagePublisher::doWork()was called, resulting in the published image being flipped back and forth all the time.This PR should be straightforward to port it to
Iron,JazzyandRolling.