Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake warnings #529

Merged
merged 2 commits into from
Oct 24, 2016
Merged

Fix CMake warnings #529

merged 2 commits into from
Oct 24, 2016

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Oct 23, 2016

Thix is a follow-up on https://github.com/ros-planning/navigation/pull/528/files that will help me fix #458 on the farm.

@vrabaud vrabaud force-pushed the kinetic_cmake_fix branch 3 times, most recently from 3a46e5d to 74227cb Compare October 23, 2016 14:11
@vrabaud
Copy link
Contributor Author

vrabaud commented Oct 23, 2016

@dirk-thomas , @mikeferguson , any idea on what is causing the GCC warning?
http://build.ros.org/job/Kpr__navigation__ubuntu_xenial_amd64/29/warnings18Result/
I could not reproduce locally but from what I could guess, it's something like

gcc -D"FOO;"

and the ";" should not be there. But that's on the PR script side and I don't know where that is. Thx.
(maybe we could run it once in verbose mode ?)

@dirk-thomas
Copy link
Contributor

You can set CMAKE_VERBOSE_MAKEFILE to TRUE in your branch to make the PR job run in verbose mode.

@vrabaud
Copy link
Contributor Author

vrabaud commented Oct 24, 2016

@dirk-thomas thx.
And all is fixed, we probably want this in asap to get other PR green too.

mikeferguson
mikeferguson reviewed Oct 24, 2016
View reviewed changes
base_local_planner/CMakeLists.txt
@@ -23,6 +23,7 @@ find_package(Boost REQUIRED

find_package(Eigen3 REQUIRED)
find_package(PCL REQUIRED)
remove_definitions(-DDISABLE_LIBUSB-1.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this coming in from PCL, or something else?

@mikeferguson mikeferguson merged commit 76712c9 into ros-planning:kinetic-devel Oct 24, 2016
@mikeferguson
Copy link
Contributor

Thanks @vrabaud!

@vrabaud
Copy link
Contributor Author

vrabaud commented Oct 24, 2016

yes, PCL brings that in but it's not present in their headers that are installed by default.

@vrabaud vrabaud deleted the kinetic_cmake_fix branch October 24, 2016 18:41
Combinacijus pushed a commit to Combinacijus/navigation that referenced this pull request Mar 27, 2024
@SteveMacenski
adding Nvidia to sponsors! (ros-planning#529)
cf33073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeferguson mikeferguson mikeferguson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vrabaud @dirk-thomas @mikeferguson