Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

costmap_2d_node: enable setting namespace from launch files #3213

Closed
tonynajjar opened this issue Sep 22, 2022 · 1 comment · Fixed by #3222
Closed

costmap_2d_node: enable setting namespace from launch files #3213

tonynajjar opened this issue Sep 22, 2022 · 1 comment · Fixed by #3222

Comments

@tonynajjar
Copy link
Contributor

tonynajjar commented Sep 22, 2022

Feature description

I want to run a standalone costmap node and set its (parent) namespace from the launch file because it is dynamically generated.
Currently this is not possible as stated in this comment

This is a feature request to enable this all while retaining the current functionality of setting the namespace via NodeOptions

If you agree, I can contribute here with some guidance what you'd like the design to look like

@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 22, 2022

Seems sensible. You may be able to find the namespaces / remaps in the main.cpp file that you can just populate into the constructor so that it uses that code to perform what you want. Its a round-a-bout way of getting the same behavior, but is the lowest technical effort I believe. Though, if you can find another way to messing with node options that doesn't break current behavior, have at it!

Edit: actually, another option would be to break this constructor apart and make a new constructor that doesn't call this line, and use that for the node. That's probably the cleanest solution.

@SteveMacenski SteveMacenski linked a pull request Sep 23, 2022 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants