publish with QoS reliable as default #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Feb 10, 2021
|
@jacobperron I think the failing tests are unrelated to the patch now |
I think so too, I'll retrigger anyways to see if there are some flakes. |
|
@ros-pull-request-builder retest this please |
jacobperron
approved these changes
Feb 18, 2021
jacobperron
pushed a commit
that referenced
this pull request
Feb 18, 2021
* default to reliable publishers
|
Forward port to Rolling: #1235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a minimal fix to ensure compatibility with rqt and other default (reliable) subscribers, while still allowing production systems to take advantage of best-effort transport, and still demonstrating the use of the recommended QoS profiles.
This is a revision of #1219
This applies only to publishers defaulting to
rclcpp::SensorDataQoS()and sets defaults torclcpp::SensorDataQoS().reliable()