Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[forward port] publish with QoS reliable as default (#1224) #1235

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

jacobperron
Copy link
Collaborator

Port #1224 to Rolling.

Default all ROS publishers in plugins to reliable QoS.

* default to reliable publishers
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good; I believe the cmake linting errors are already fixed by #1249

@jacobperron
Copy link
Collaborator Author

@osrf-jenkins run tests please

@jacobperron
Copy link
Collaborator Author

@ros-pull-request-builder retest this please

1 similar comment
@jacobperron
Copy link
Collaborator Author

@ros-pull-request-builder retest this please

@jacobperron jacobperron merged commit da14a69 into ros2 Mar 18, 2021
@jacobperron jacobperron deleted the jacob/forward_port_1224 branch March 18, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants