Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazebo_ros[2]: Add missing exec dependencies #1291

Merged
merged 1 commit into from
Jul 14, 2021
Merged

gazebo_ros[2]: Add missing exec dependencies #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions gazebo_ros/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@
<depend>std_srvs</depend>
<depend>tinyxml_vendor</depend>

<exec_depend>ament_index_python</exec_depend>
<exec_depend>geometry_msgs</exec_depend>
<exec_depend>launch_ros</exec_depend>
<exec_depend>python3-catkin-pkg</exec_depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we sure we want python3-catkin-pkg in the foxy branch?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is imported here:

gazebo_ros_pkgs/gazebo_ros/scripts/gazebo_ros_paths.py

Line 32 in 3f18465

from catkin_pkg.package import InvalidPackage, PACKAGE_MANIFEST_FILENAME, parse_package

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is fine, though I think we could replace this logic with equivalent ament API calls in a follow-up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I guess it's even used in ros2pkg (ros2/ros2cli#94):

<exec_depend>ros2pkg</exec_depend>
<exec_depend>std_msgs</exec_depend>

<build_export_depend>geometry_msgs</build_export_depend>
<build_export_depend>sensor_msgs</build_export_depend>
Expand Down