Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TBB in gazebo-dev cmake to fix #1372 #1373

Merged
merged 7 commits into from
May 3, 2022
Merged

Include TBB in gazebo-dev cmake to fix #1372 #1373

merged 7 commits into from
May 3, 2022

Conversation

j-rivero
Copy link
Contributor

Workaround for problem described in #1372.

The CMake code for detecting TBB was copied directly from Gazebo11.

@j-rivero
Include TBB in gazebo-dev cmake to fix #1372
9668830 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from ahcorde April 27, 2022 14:49
@j-rivero
Copy link
Contributor Author

Jammy build was able to reach the end although several problems are affecting it:

This was referenced May 2, 2022
Merged
Closed
@chapulina chapulina requested review from jacobperron and scpeters May 2, 2022 18:05
jacobperron
jacobperron reviewed May 2, 2022
View reviewed changes
Copy link
Collaborator

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

gazebo_dev/cmake/gazebo_dev-extras.cmake Outdated Show resolved Hide resolved
gazebo_dev/cmake/gazebo_dev-extras.cmake Outdated Show resolved Hide resolved
gazebo_dev/cmake/gazebo_dev-extras.cmake Outdated Show resolved Hide resolved
gazebo_dev/cmake/gazebo_dev-extras.cmake Outdated Show resolved Hide resolved
gazebo_dev/cmake/gazebo_dev-extras.cmake Outdated Show resolved Hide resolved
gazebo_dev/cmake/gazebo_dev-extras.cmake Outdated Show resolved Hide resolved
j-rivero and others added 6 commits May 3, 2022 17:56
@j-rivero @jacobperron
Update gazebo_dev/cmake/gazebo_dev-extras.cmake
9f8db00 
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@j-rivero @jacobperron
Update gazebo_dev/cmake/gazebo_dev-extras.cmake
24ae78c 
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@j-rivero @jacobperron
Update gazebo_dev/cmake/gazebo_dev-extras.cmake
231b7bb 
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@j-rivero @jacobperron
Update gazebo_dev/cmake/gazebo_dev-extras.cmake
39b1fae 
Co-authored-by: Jacob Perron <jacob@openrobotics.org>
@j-rivero
Remove extra spaces
15e2669 
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero
Fix issue number
c3556ca
@j-rivero
Copy link
Contributor Author

j-rivero commented May 3, 2022

@osrf-jenkins run tests

@j-rivero
Copy link
Contributor Author

j-rivero commented May 3, 2022

Humble and Rolling are fine with the exception of lintian and failing tests not related to this PR

@j-rivero j-rivero requested a review from jacobperron May 3, 2022 18:49
jacobperron
jacobperron approved these changes May 3, 2022
View reviewed changes
Copy link
Collaborator

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for unblocking CI.

I think we can tackle the test failures separately.

@jacobperron jacobperron merged commit 9954bb9 into ros2 May 3, 2022
@jacobperron jacobperron deleted the jrivero/1372_fix branch May 3, 2022 20:08
BrettRD pushed a commit to BrettRD/gazebo_ros_pkgs that referenced this pull request Aug 12, 2022
@j-rivero @jacobperron
Include TBB in gazebo-dev cmake to fix ros-simulation#1372 (ros-simul…
06a118a 
…ation#1373)

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@BrettRD BrettRD mentioned this pull request Aug 12, 2022
Draft
Minipada pushed a commit to brisa-robotics/gazebo_ros_pkgs that referenced this pull request Nov 13, 2022
@j-rivero @jacobperron @Minipada
Include TBB in gazebo-dev cmake to fix ros-simulation#1372 (ros-simul…
725b0e6 
…ation#1373)

Co-authored-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobperron jacobperron jacobperron approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

@scpeters scpeters Awaiting requested review from scpeters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-rivero @jacobperron