Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow tf2 name convention #40

Open
wants to merge 1 commit into
base: lunar-devel
Choose a base branch
from

Conversation

ompugao
Copy link

@ompugao ompugao commented Dec 20, 2016

A leading slash of frame_id should be stripped.
see http://wiki.ros.org/tf2/Migration.

@wjwwood wjwwood closed this May 1, 2017
@wjwwood wjwwood changed the base branch from master to lunar-devel May 1, 2017 03:23
@wjwwood
Copy link
Member

wjwwood commented May 1, 2017

Sorry, I accidentally closed this when changing the branch layout of the repository. I've reopened it and updated the target base to be lunar-devel which is the new default branch. You can edit again to point at indigo-devel, which is what is used to release for ROS Indigo and Kinetic, if you like.

@wjwwood wjwwood reopened this May 1, 2017
@ompugao
Copy link
Author

ompugao commented May 1, 2017

please merge this pr into lunar-devel if you like.

@croesmann
Copy link

this issue is now very crucial to me.
In melodic, the navigation stack migrated to tf2.
Running now stage_ros with multiple robots and the navigation stack for at least one of them
spams the following error

[ERROR] [1533643336.506100416, 271.300000000]: TF Exception that should never happen for sensor frame: , cloud frame: /robot_0/base_laser_link, Invalid argument "/robot_0/base_laser_link" passed to lookupTransform argument source_frame in tf2 frame_ids cannot start with a '/' like:

which is indeed correct, since stage_ros defines the frame id as "/robot_0/base_laser_link" and not "robot_0/base_laser_link".

Is there any chance to get this into melodic @wjwwood? I would like to push a melodic release of the teb_local_planner_tutorials but all the multiple robot configurations fail due to the issue mentioned above.

thanks a lot!

croesmann added a commit to rst-tu-dortmund/teb_local_planner_tutorials that referenced this pull request Aug 7, 2018
@wjwwood
Copy link
Member

wjwwood commented Aug 7, 2018

Sorry, I don't have time to maintain this repository beyond doing releases, but I believe @rtv is helping review and merge things as he has time.

@amattag
Copy link

amattag commented Mar 12, 2020

Has this problem been fixed in ros-melodic-stage?
I am having this problem with ros melodic. The /robot_0/base_laser_link frame name must be changed to robot_0/base_laser_link frame. Otherwise a simulation with multiple robots/objects will not work.
Had to switch back to ros-kinetic.

@croesmann
Copy link

The fix is still crucial for multi robot simulations in stage, would be great if we could get this in.

@AndyHuska
Copy link

+1 for merging this pull request, it's ready to go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants