Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest binary ros2 windows distributions #450

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

wmmc88
Copy link
Contributor

@wmmc88 wmmc88 commented Sep 25, 2021

No description provided.

@wmmc88 wmmc88 force-pushed the patch-1 branch 5 times, most recently from 45a5906 to 08b1609 Compare September 26, 2021 02:46
Signed-off-by: Melvin Wang <melvin.mc.wang@gmail.com>
@codecov
Copy link

codecov bot commented Sep 26, 2021

Codecov Report

Merging #450 (fdbdf5a) into master (60765f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #450   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files           8        8           
  Lines         160      160           
  Branches       14       14           
=======================================
  Hits          149      149           
  Misses         11       11           
Impacted Files Coverage Δ
src/setup-ros-windows.ts 77.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60765f0...fdbdf5a. Read the comment docs.

src/setup-ros-windows.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@emersonknapp emersonknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine - is there any way you can think of that we could pull "latest release" automatically instead of the hardcoding here?

@christophebedard
Copy link
Member

This all looks fine - is there any way you can think of that we could pull "latest release" automatically instead of the hardcoding here?

I've thought about this too. We could fetch releases using the GitHub API and check the tags. The tag format is always release-$DISTRO-YYYYMMDD. Then we check the assets and pick the one for a given platform. This part might be a bit trickier, but it should work.

Signed-off-by: Melvin Wang <melvin.mc.wang@gmail.com>
@wmmc88 wmmc88 marked this pull request as ready for review September 27, 2021 21:03
@wmmc88 wmmc88 requested a review from a team as a code owner September 27, 2021 21:03
@wmmc88 wmmc88 requested review from MichaelOrlov and lucashan and removed request for a team September 27, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants